Magus Zeal
Expert II
According to UOguide, when remove trap skill is at 80, you should train at GM. However, the code does not jive here:
The range to remove trap is defined in RemoveTrap.cs
if (from.CheckTargetSkill(SkillName.RemoveTrap, targ, targ.TrapPower, targ.TrapPower + 10))
It calls trappower, which is defined in DefTinkering.cs
if (message == 0)
{
int trapLevel = (int)(From.Skills.Tinkering.Value / 10);
Container.TrapType = TrapType;
Container.TrapPower = trapLevel * 9;
Container.TrapLevel = trapLevel;
Container.TrapOnLockpick = true;
message = 1005639; // Trap is disabled until you lock the chest.
}
Based on that, we can compute the ranges:
At 100 tinkering,
Trappower= 100/10*9 = 90
Therefore the range is = 90-100 (trappower to trappower+10)
UoGuide's range at GM tinkering is 80-100. The formula is computing 90-100. So I think either the divisor for trappower should be 8 or the range needs to subtract 10 for the minimum level to agree with UOGuide's range.
The range to remove trap is defined in RemoveTrap.cs
if (from.CheckTargetSkill(SkillName.RemoveTrap, targ, targ.TrapPower, targ.TrapPower + 10))
It calls trappower, which is defined in DefTinkering.cs
if (message == 0)
{
int trapLevel = (int)(From.Skills.Tinkering.Value / 10);
Container.TrapType = TrapType;
Container.TrapPower = trapLevel * 9;
Container.TrapLevel = trapLevel;
Container.TrapOnLockpick = true;
message = 1005639; // Trap is disabled until you lock the chest.
}
Based on that, we can compute the ranges:
At 100 tinkering,
Trappower= 100/10*9 = 90
Therefore the range is = 90-100 (trappower to trappower+10)
UoGuide's range at GM tinkering is 80-100. The formula is computing 90-100. So I think either the divisor for trappower should be 8 or the range needs to subtract 10 for the minimum level to agree with UOGuide's range.