FIXED Runic Reforging mods are no where near accurate.

[DewCono]

When attempting to reforge myself a shield with Damage Increase, and a 100% elemental damage weapon I used a few hundred runic charges on each in the process. When it comes down to weapons not only did I never receive a 100% elemental damage weapon, I never received even a 10% damage weapon. When looking further into this I checked the code for reforging in specific, and I found the results to be:

Snippet - exquisite / of quality weapon

m_PrefixSuffixInfo[5] = new NamedInfoCol[][] // Exquisite
{
new NamedInfoCol[] // Weapon
{
new NamedInfoCol(AosWeaponAttribute.SelfRepair, SelfRepairTable),
new NamedInfoCol(AosWeaponAttribute.DurabilityBonus, DurabilityTable),
new NamedInfoCol(AosWeaponAttribute.HitLowerDefend, HitWeaponTable2),
new NamedInfoCol(AosWeaponAttribute.LowerStatReq, LowerStatReqTable),
new NamedInfoCol("Slayer", 1),
new NamedInfoCol(AosWeaponAttribute.MageWeapon, MageWeaponTable),
new NamedInfoCol(AosAttribute.SpellChanneling, 1),
new NamedInfoCol(AosAttribute.BalancedWeapon, 1),
new NamedInfoCol("WeaponVelocity", WeaponVelocityTable),
},

Snippet - vicious / of slaughter (has no shield specific area at all)

m_PrefixSuffixInfo[11] = new NamedInfoCol[][] //Vicious
{
new NamedInfoCol[] // Weapon
{
new NamedInfoCol("HitSpell", HitWeaponTable1),
new NamedInfoCol("HitArea", HitWeaponTable1),
new NamedInfoCol(AosAttribute.AttackChance, WeaponHCITable, RangedHCITable),
new NamedInfoCol(AosAttribute.WeaponDamage, WeaponDamageTable),
new NamedInfoCol(AosWeaponAttribute.BattleLust, 1),
new NamedInfoCol(AosWeaponAttribute.SplinteringWeapon, 30),
new NamedInfoCol("Slayer", 1),
},
new NamedInfoCol[] // armor
{
new NamedInfoCol(AosAttribute.AttackChance, ArmorHCIDCITable),
},
new NamedInfoCol[]
{
new NamedInfoCol(AosAttribute.AttackChance, WeaponHCITable),
},
new NamedInfoCol[]
{
new NamedInfoCol(AosAttribute.AttackChance, WeaponHCITable),
new NamedInfoCol(AosAttribute.SpellDamage, 15),
},
};

I don't exactly know how the intensities are determined since it seems like the logic for that is in another area, I also only checked for the mods I attempted to roll, and couldn't.

Sources :
https://uo.com/wiki/ultima-online-wiki/skills/imbuing/runic-reforging/
https://github.com/ServUO/ServUO/bl...pts/Services/RunicReforging/RunicReforging.cs
http://www.uoguide.com/Runic_Re-Forging#Re-Forging_properties_by_name

 

[xG00BERx]

DewCono, I’m not sure if you’re using your Heritage gold, runics, etc to find the issues with reforging or not but if you indeed are wasting your resources to find issues I’d be willing to open a private server for you to join and have unlimited uses of runics etc so you wouldn’t have to waste your actual resources...
Just let me know, I think this might be more beneficial for you & your situation as I think everyone benefits from your bug reports in regards to Runic Reforging... I personally don’t do any of it because once upon a time a guild mate of mine who understood it did it and said it was broke and I’m not willing to waste resources to fix a bug lol

Anyways, let me know if you’d like me to setup a live server and a way for you to join and expieriment, thanks for all the hard workkkkk.

 

[DewCono]

I do in fact do my testing with my heritage stuff. I downloaded the servuo source but ran into some errors setting it up, and haven't tried since. If you're willing to do that it'd be nice. I just haven't had a clear idea on what my end goal is so I've just been keeping myself busy (testing monsters and systems that have been neglected for a while).
Hopefully when am these wrinkles get ironed out more people will show up. I just want to see the server thrive.

 

[Brave Sir Robin]

I have had no luck either with runic tools giving any Sort of elemental damage using exquisite/of quality. I've burned through several hammers up to bronze

 

[DewCono]

Has this been looked into at all? Reforging is still also rolling properties from pools it shouldn't. If you select 2 prefix /suffix you should not receive any mods from any other pools (which is partly why reforging with higher runic tools on osi isn't worth it) and that's still also happening while reforging.

 

[Dan]

Nope, but it will get looked at when someone has time. For now any additional information and testing will greatly speed everything up once we have time to look at this system.

 

[DewCono]

I'm going to see about getting on OSI for testing. Do EJ accounts have TC access? I'll make a video doing both actions on Servuo (goober's test realm) and OSI TC if so

 

[Dan]

Yes they do.

 

[DewCono]

Well I know where my night just went. Hopefully I can collect enough info to have this fixed soon.. I got suits to make!

 

[Dexter]

So, they just aren’t getting elemental damage?

 

[Dexter]

Has this been looked into at all? Reforging is still also rolling properties from pools it shouldn't. If you select 2 prefix /suffix you should not receive any mods from any other pools (which is partly why reforging with higher runic tools on osi isn't worth it) and that's still also happening while reforging.

This is not true. Additional mods are random, and not necessarily from another specific pool of mods.

 

[DewCono]

That's the case if it were left on completely random, or if only one prefix /suffix is chosen. If you have both selected it should search the current pool until it's out of mods. This can be easily tested on tc with runic kits once I get on there.
Weapons are rolling no elemental damage at all, shields aren't rolling damage increase at all either.

 

[Dexter]

Please verify for prefix and siffox chosen all mods stay within the pool. I did tons of testing on this a while back and seem to remember a random mod. I could be wrong. The other issues are easy.

 

[Dan]

Was this basically fixed with the most recent update?

 

[Dexter]

I’m still waiting on verification that two named mods will roll ALL properties from those pools.

 

[DewCono]

Is confirmation needed on OSI or on ServUO? I can test either way just let me know specifically what you'd like me to test out.

 

[Dexter]

This is what I was referring to:

That's the case if it were left on completely random, or if only one prefix /suffix is chosen. If you have both selected it should search the current pool until it's out of mods. This can be easily tested on tc with runic kits once I get on there.

 

[Dexter]

Property distribution is per EA.

 

[Dan]

This issue has been fixed.

@DewCono has been awarded 10 Sovereigns.