Not A Bug Runic Reforging Code

[Magus Zeal]

The code in runic reforging has a spelling mistake where the variable perchi is being mispelt. so you never get a high min.



I just posted this over on ServUO but I should have posted it here instead.

Anyways perchi isn't defined anywhere (search perchi =) but perchigh is and is used alot in other places.

 

[Dan]

I fired up Visual Studios to take a look. While still a great find the method itself seems to be older code that can actually be removed. I will send a PR correcting the spelling mistake but I believe the end result will actually be this bit of code gets removed, as currently it seems nothing actually calls it.

 

[Dan]

A new method was probably introduced later. Sometimes a coder will leave the old method incase you need to quickly switch back. perchi may have been the original name a while ago. A lot of times leftover code gets forgotten and can indeed be confusing. Going to wait for Dexter to confirm this one before I touch the loot code.

 

[Magus Zeal]

Ya I see that now. I should have checked to see where calculateminintensity() was being used. Thank you for having a look @Dan