Not A Bug Pet Masteries "Combat Training" and "Whispering" don't refer to mastery level

[Magus Zeal]

The pet masteries in the ServUO git don't call the function "GetMasteryLevel()" which leads me to believe that mastery level is not helping tamers at all with these skills.

Example:
https://github.com/ServUO/ServUO/blob/master/Scripts/Spells/Skill Masteries/Whispering.cs

Yet, with skills that do work, this function exists:
https://github.com/ServUO/ServUO/blob/master/Scripts/Spells/Skill Masteries/DeathRay.cs (see line 80)

 

[Dexter]

BaseSkillBonus on line 87:

        public virtual double BaseSkillBonus 
        {
            get
            {
                if(Caster == null)
                    return 0.0;
                    
                return (Caster.Skills[CastSkill].Value + Caster.Skills[DamageSkill].Value + (GetMasteryLevel() * 40)) / 3;
            }
        }

 

[Magus Zeal]

Thank you - I saw that - but I thought it was just spells being effected Castskill+Damage skill (eval/magery)- not pet mastery abilities. See im all confused with scripts - help me understand: what does that mean for consume damage? Or As One?

 

[DewCono]

If you look at SkillMasterySpell.cs you'll find the snippet Dexter referenced up there. In most of the mastery spells like Whispering it defines the castskill+damageskill as cast=taming/damage=lore.

So by default Base skill bonus if you're 120/120/level 3 you have a bonus of 360, 100/100/2 you have a bonus of 280, etc.