FIXED Maritime Cargo For Other City

[Magus Zeal]

Martime Cargo is supposed to reward gold to the city regardless of where you deliver it. The rates are half for a city that is a different destination (i.e. Delivered to moonglow but cargo is for yew).

I just burned not one, but two mythical cargo on moonglow destined to another down and got zero gold added. Its a bummer cause I have been working hard at getting these

Rising Tide - https://uo.com/wiki/ultima-online-wiki/combat/pvm-player-versus-monster/rising-tide/


Maritime Cargo Crate City Treasury Values (https://www.uo-cah.com/pub-104/rising-tide-guide)

	Grandmaster Quality	Exalted Quality	Legendary Quality	Mythical Quality
Matching Town	~150K to 190K Gold	~500K to 600K Gold	~1,000,000 Gold	~10,000,000 Gold
Non-Matching Town	~70K to 80K Gold	~250K to 300K Gold	~500,000 Gold	~5,000,000 Gold

 

[Magus Zeal]

The uo.com rising tide link just says "half the value for non-matching cities"
CAH - provides specific values.

 

[Magus Zeal]

I see all these new bugs getting love before this one so I'm going to BUMP

 

[Magus Zeal]

So this is the offending code. It is stating if cargo matches city, add to treasury, else 100 (lol). The else should be calculating 50% of if the city did match.

ServUO/Scripts/Services/City Loyalty System/Trading/DonationCrate.cs at 74c1563580afe635816d8532a41bf91cee7117ec · ServUO/ServUO

An Ultima Online server emulator written in C# .NET - ServUO/ServUO

github.com

private void AddToTreasury(CityLoyaltySystem system, MaritimeCargo cargo)
        {
            if (system != null)
            {
                if (cargo.City == City)
                {
                    system.AddToTreasury(null, cargo.GetAwardAmount() * 1000);
                }
                else
                {
                    system.AddToTreasury(null, 100);
                }
            }
        }

The else should be:

system.AddToTreasury(null, cargo.GetAwardAmount() * 1000 * 0.5);

 

[Dan]

This issue has been fixed.

@DaBeanCounter has been awarded 25 Sovereigns.