FIXED Curse overrides armor refinement modifications

[DewCono]

When cursed I should lose 10% to each elemental resist, (which some are over 70) however when cursed the tooltip says -10% to max resist, but applies that ontop of cancelling my armor refinement for those resistances.

 

[DewCono]

if (type != ResistanceType.Physical && 60 < max && Spells.Fourth.CurseSpell.UnderEffect(this))

{

max = 60;
}

line 1009 of https://github.com/ServUO/ServUO/blob/master/Scripts/Mobiles/PlayerMobile.cs - Thanks Lokai

 

[Dan]

So what's the bug? The amount or the tooltip?

 

[DewCono]

The amount. it should reduce max resist by 10, but instead the code just assumes 70 is the original max, and sets it to 60. It's not considering the armor refinement modifying the original max resist.

 

[Dan]

Thanks you confused me in your original post by saying 10% when you meant 10. 10% and 10 are not the same. I am tracking 10 now though.

 

[DewCono]

Yeah, sorry about that. I always look at the resists as % in my head since 70 phys resist is literally 70% physical damage reduction.

 

[Dexter]

This needs to be verified in EA.

 

[Dan]

I did verify this on EA. I had posted on it again prior to ServUO going down. It is the sole reason they are used, to bump up the total number you can get in fire so when you get cursed it still have a few more in fire resist points, in return for lower DCI.

 

[Dan]

It is only for refinements. Obviously stone form, ect acts normal.

 

[Dexter]

Ok, gotcha!

 

[Dan]

This has been fixed right @DewCono?

 

[DewCono]

I will have to test it out.