FIXED Counter Attack InRange() check is incorrect

[Magus Zeal]

@GiantFreakishApe and I just went on EA to test counter attack. I was an archer and he counterattacked me with a special from a range.

In servuo there is a range check where CA only works up close:

Baseweapon.cs

if (CounterAttack.IsCountering(defender) && defender.InRange(attacker.Location, 1))

Here is the video evidence on EA:

2020.05.28-02.31_02

Watch "2020.05.28-02.31_02" on Streamable.

streamable.com

We decided to test on EA after we couldn't get it to work on Heritage.

 

[FireFly]

Ah i always think it works here... Looks like not...

 

[GiantFreakishApe]

This thread warms my heart

 

[Dan]

Any idea IF there is a range check? 5 tiles? 10 tiles?

 

[Magus Zeal]

Dan we will need to test the range - I was at least 8 tiles away in that video - I think 10 tiles is the max for all ranged type stuff. But I don't think we need that check because archers and mages already have range checks. If they cant hit then its out of range. If they cant hit there is nothing to counter. Not that spells can be counter attacked haha. but for archers and throwers their inherent range checks for hitting will make sure this cant happen screens away.

 

[Dan]

Awesome thanks!

 

[Magus Zeal]

So no need to check the range right?

 

[Dexter]

The range check is already done for shooting an arrow I would imagine.

 

[Dan]

Yeah @DaBeanCounter is correct I believe. The range check would be prompted by the one doing the attack. No need for another check.

 

[Dan]

This issue has been fixed.

@DaBeanCounter has been awarded 20 Sovereigns.