FIXED Fey Slayer damage calculation is wrong

[adverserath]

According to UO.com the fey slayer should hit at 3x damage, not the super slayer 2x

• Fey Slayer is a special super slayer category that does triple damage.

Fix Branch:

Fey Slayer Damage is wrong by adverserath · Pull Request #1078 · TrueUO/TrueUO

Remove Fey Slayer from BaseWeapon checks, its a special slayer that should do 3 times damage

github.com

Slayer Property Items – Ultima Online

uo.com

 

[adverserath]

Tested in OSI. Using Composite Bow.
155 with Fey Slayer and Armour Ignore
55 without Fey Slayer and Armour Ignore

 

[Dan]

So removing it where you made the edit makes it default to 3x?

 

[adverserath]

Yes, that slayer group in BaseWeapon is only used once and that is to detect if it is a super slayer. Removing it there makes it fall into the monster slayer check instead.

 

[Dan]

Good stuff! I'm at school right now but I'll get it in there later today.

 

[Dan]

If there are fey talismans do they also do a double check off of BaseWeapon or maybe something I should dig into a little more?

 

[FireFly]

There is no fey slayer talismans

 

[adverserath]

If there are fey talismans do they also do a double check off of BaseWeapon or maybe something I should dig into a little more?

I just tested and fixed the Fey Spellbooks damage too. Would be cleaner if the Super Slayers had an enum.

If you want to do any extra test in TC theres a character setup already called "Missalot". They have a Fey Bow and Fey Spellbook.

 

[spezio]

There is no fey slayer talismans

you can get a cameo fey slayer!

 

[FireFly]

you can get a cameo fey slayer!

You are wrong/ if there is fey cameo it should not exists.

"There are 6 different super slayers in the set, only super slayer not includes is the set is Fey."

Enchantress’ Cameo - UOGuide, the Ultima Online Encyclopedia

www.uoguide.com

 

[Dan]

You are wrong/ if there is fey cameo it should not exists.

"There are 6 different super slayers in the set, only super slayer not includes is the set is Fey."

Enchantress’ Cameo - UOGuide, the Ultima Online Encyclopedia

www.uoguide.com

I double-checked, Cameos are not coded to spawn with Fey in the code either.

TrueUO/Scripts/Services/Dungeons/Shadowguard/Artifacts.cs at master · TrueUO/TrueUO

https://discord.gg/5RtDbkY3fC. Contribute to TrueUO/TrueUO development by creating an account on GitHub.

github.com

 

[FireFly]

@spezio no fey cameo

 

[Dan]

This issue has been fixed.

@adverserath has been awarded 25 Sovereigns for reporting and also submitting the suggested code change.