FIXED constant reminder nobody loves me, i have 0 messages :(

[Miral]

it's Miral btw

 

[Dan]

Character name?

Is it only one character on the account or all on that account who receive it?

 

[Miral]

it's Miral, and just cycled through my chars and only Miral gets the box pop up

 

[Dan]

How long ago did you abandon the magincia vendor?

It happens every time since then?

 

[Miral]

not 100% but i feel like it's been gone between 1-2 weeks and when I had the pet vendor it would only pop up when I had 1 message saying it had been renewed, i'd delete it and the box would go away. now it is always just there, with no messages. I can dismiss it by right clicking it, but if I log in - it's back again - 0 messages

if I click it I get this...


if i click the + i get this...

 

[Dan]

TrueUO/Scripts/Services/New Magincia/Housing Lotto/Core/MaginciaLottoSystem.cs at master · TrueUO/TrueUO

https://discord.gg/5RtDbkY3fC. Contribute to TrueUO/TrueUO development by creating an account on GitHub.

github.com

if (m_MessageQueue[from].Count == 0)

public static void RemoveMessageFromQueue(Mobile from, NewMaginciaMessage message)
        {
            if (from == null || message == null)
                return;

            if (m_MessageQueue.ContainsKey(from) && m_MessageQueue[from].Contains(message))
            {
                m_MessageQueue[from].Remove(message);

                if (m_MessageQueue[from].Count == 0)
                {
                    m_MessageQueue.Remove(from);
                }

                return;
            }

I think, somehow, your message count entered a negative count. Since it was never = 0, it never removed itself.

IE - -1, -2, -3.

if (m_MessageQueue[from].Count == 0)

Going to see if this does it.

if (m_MessageQueue[from].Count <= 0)

 

[Dan]

MessageFix by TrueUO · Pull Request #996 · TrueUO/TrueUO

https://discord.gg/5RtDbkY3fC. Contribute to TrueUO/TrueUO development by creating an account on GitHub.

github.com

- Was not that. Will be fixed with the July 1st patch.

 

[Pappy]

I have the same thing on at least one character.
Started from the last raffle.
Usually it tells me 'sorry, you didn't win this time' or something like that.
Didn't get that message this time around though,

 

[Dan]

I have the same thing on at least one character.
Started from the last raffle.
Usually it tells me 'sorry, you didn't win this time' or something like that.
Didn't get that message this time around though,

Yeah, when this patch gets pushed what will happen is you will all actually get the messages in the queue that are not showing up to the final menu correctly. It is showing 0 incorrectly.

When I tested on Mirals character I also got a message that I had not won the raffle afterward.

 

[Dan]

it's Miral, and just cycled through my chars and only Miral gets the box pop up

When you get a moment, please let me know if the messages now appear and let you clear them out correctly.

 

[Pappy]

Now shows 1 message but cannot open it or delete it.
Edit (was finally able to get it to open then delete)

 

[Dan]

Worked the first try for me. Just need to click the right spot.

 

[Dan]

I believe the issues with these message menus have been resolved.

@Miral has been awarded 10 Sovereigns.

 

[Miral]

it has, no 0 messages anymore