FIXED Large BOD of instruments has no small bods

[adverserath]

I have a few large bods for instruments:
new RewardType(250, typeof(LapHarp), typeof(Lute), typeof(Drums), typeof(Harp))

But there are no instrument small bods being generated, as far as i can tell.

 

[Omalley]

I have just under 2k carpentry bods.. and not one small instrument bod.. so I would have to say that he is right.

 

[Dan]

Hmm, alright I'll take a look.

 

[Cid]

I just finished checking my nearly 600 carp BODS.....no small instrument BOD'S

 

[Dan]

TrueUO/Data/Bulk Orders/Carpentry/smalls.cfg at bc2334c9b50df19431a8cb20faf256024c68fc60 · TrueUO/TrueUO

https://discord.gg/5RtDbkY3fC. Contribute to TrueUO/TrueUO development by creating an account on GitHub.

github.com

At first glance I don't understand why since I see them coded there with the other Carpentry smalls.

 

[FireFly]

Lets try UO logic to get them-
Maybe they only roll for character with all required skills to made them? Try soul stone and add some music to your carp

 

[Omalley]

Lets try UO logic to get them-
Maybe they only roll for character with all required skills to made them? Try soul stone and add some music to your carp

i wouldnt think the npc would be checking the music skill.. but.. i could be wrong

 

[Sky]

I don't see them often but do get them.

 

[Dan]

I don't see them often but do get them.
View attachment 4214

Thank you for confirming their existence atleast.

 

[Omalley]

lol, wow.. roughly 2600 bods checked, and none.. and Sky has 4! hackz!

 

[Dan]

I removed all the smalls in that data file, except the instruments, and grabbed a bunch of carp bulk orders and it all seems to be working okay. They generated. Keep an eye on it.

 

[Cid]

I'll add music to my mule for tomorrows BOD cycle.....keeping my fingers crossed...

 

[Dan]

I'll add music to my mule for tomorrows BOD cycle.....keeping my fingers crossed...

Music plays no part here. Not a bad idea though @FireFly

Sometimes it is something weird like that and I had to look and double check that wasn't the case.

 

[Cid]

Glad to hear that music plays no part. Before I read this, I went ahead and put GM music on the mule....no small instrument BOD'S. I even turned in a completed BOD....still no instrument.

Is the dreaded RNG gremlin at play again?

Thanks for looking into this.....Enjoy the rest of the Holiday

 

[Cid]

Need to bump this back to the top.

It's been 3 months and I still have not received a small bod for instruments. My total small Carp bods number close to 1k and I have never received a small instrument bod since I have been on this shard.

Surly the RNG can't be that off.....or can it?

 

[Cid]

Currently I have 815 Small Carp bods and 98 Large Carp bods.

Of the large 28 are music bods with 23 being exceptional and 8 normal.

I don't know how many total Carp bods I have had in the 461 days I have been on the shard as I have turned in quite a few.

Something does not seem right to me.

 

[Dan]

I don't know.

Code wise it looks fine. When I tested before it also was working fine.

Since anyone can download the shard package and test I'd appreciate a second opinion if anyone out there sees this, has the know how, and gets some time.

TrueUO/Data/Bulk Orders/Carpentry at master · TrueUO/TrueUO

https://discord.gg/5RtDbkY3fC. Contribute to TrueUO/TrueUO development by creating an account on GitHub.

github.com

Bulk Order Data on creation is pulled from here. It is done by itemID.

 

[Cid]

Yeah, I don't know whats going on either. It just seems to me that while gathering 3 bods a day for 451 days and zero small instrument bods were gathered there has to be a problem somewhere. I have rotten luck but it think it's gone beyond luck. The RNG gods really hate me....Guess I better stay away from my bookie and Vegas....

I'm not a programmer so hopefully someone with some free time and more skills than I can have a look see. Meanwhile I shall plod along...

Thanks for checking Dan.

 

[Sky]

Bulk orders are skill based as far as which smalls you'll get. If you create an elf character with .1 in collecting skills it will only get small bods that take 0 skill to craft where a human character with .1 will get smalls that take 20 or less skill because of jack of all trades. So in order to get instrument smalls should need to have min base to craft which requires 45 music as well as carpentry. Large bods are random anytime after 70.1 base skill.

 

[Cid]

Music plays no part here. Not a bad idea though @FireFly

Sometimes it is something weird like that and I had to look and double check that wasn't the case.

I think the need to have music on your toon to get small music bods has been laid to rest.

I'll add music to my mule for tomorrows BOD cycle.....keeping my fingers crossed...

Glad to hear that music plays no part. Before I read this, I went ahead and put GM music on the mule....no small instrument BOD'S. I even turned in a completed BOD....still no instrument.

Is the dreaded RNG gremlin at play again?

Thanks for looking into this.....Enjoy the rest of the Holiday

My mule char has 120 tailoring and still pulls small normal cloth bods, so following your logic he should only pull large exceptional bods? Just because I have 100 skill in Carpentry doesn't mean I won't pull any small bods, I get smalls all the time. Just not small music bods.