FIXED Servuo TOL Bug wrt to Rising Tide

[Magus Zeal]

While setting your server expansion to TOL, you are unable to load the galleon ship cannon without crashing the server.

Steps to reproduce:

Change expansion.cfg to "TOL"
"recompile"
place a galleon
place a cannon addon
step through charging, then loading the cannon
once the cannon is "loaded" the server will crash.

I think the new EJ, rising tide codes are missing a check somewhere (not sure, very new to this)

Here is the debug crash dump of the server:

Server Crash Report

===================



ServUO Version 0.5, Build 7264.20700

Operating System: Microsoft Windows NT 6.2.9200.0

.NET Framework: 4.0.30319.42000

Time: 11/21/2019 4:32:58 PM

Mobiles: 102

Items: 2262

Exception:

System.NullReferenceException: Object reference not set to an instance of an object.

   at Server.Network.DisplayGumpPacked.AppendLayout(String text) in D:\Desktop\servuo\trunk\Server\Network\Packets.cs:line 2903

   at Server.Gumps.GumpHtmlLocalized.AppendTo(IGumpWriter disp) in D:\Desktop\servuo\trunk\Server\Gumps\GumpHtmlLocalized.cs:line 280

   at Server.Gumps.Gump.Compile(NetState ns) in D:\Desktop\servuo\trunk\Server\Gumps\Gump.cs:line 468

   at Server.Gumps.Gump.SendTo(NetState state) in D:\Desktop\servuo\trunk\Server\Gumps\Gump.cs:line 406

   at Server.Mobile.SendGump(Gump g, Boolean throwOnOffline) in D:\Desktop\servuo\trunk\Server\Mobile.cs:line 7548

   at Server.Mobile.SendGump(Gump g) in D:\Desktop\servuo\trunk\Server\Mobile.cs:line 7541

   at Server.Items.BaseCannon.ResendGump(Mobile from) in D:\Desktop\servuo\trunk\Scripts\Services\Expansions\High Seas\Items\Cannons and Ammo\Cannon.cs:line 1100

   at Server.Items.BaseCannon.Load(Object state) in D:\Desktop\servuo\trunk\Scripts\Services\Expansions\High Seas\Items\Cannons and Ammo\Cannon.cs:line 986

   at Server.Timer.DelayStateCallTimer.OnTick() in D:\Desktop\servuo\trunk\Server\Timer.cs:line 732

   at Server.Timer.Slice() in D:\Desktop\servuo\trunk\Server\Timer.cs:line 409

   at Server.Core.Main(String[] args) in D:\Desktop\servuo\trunk\Server\Main.cs:line 673



Clients:

- Count: 1

+ 127.0.0.1: (account = admin) (mobile = 0x65 'Generic Player')

 

[Dexter]

Does this happen every time?

 

[Magus Zeal]

Yes it does - crashed it many times while I narrowed it down to TOL expansion.

 

[Dexter]

Was this on existing cannons, or newly placed cannons?

 

[Magus Zeal]

Newly placed. I was also "Staff" on this test server so there is that. However, I was also staff when i switched back to EJ and repeated the procedure, which did not crash the shard. Not sure.

Have you tried reproducing the crash in TOL as described in the OP?

 

[Dexter]

I have a fix. Thanks!

 

[Dan]

@DaBeanCounter has been awarded 25 Sovereigns.