FIXED Scrolls of Transcendence binding

[BBB]

I have used scroll binder to bind alchemy pink scrolls up to 5 and at the end i got scammed

It gets even more interesting because i made a proper one +5 alchemy SoT just a moment before.

Maybe it's the order in which the scrolls are added. I also noticed math going crazy sometimes when you bind SoTs.

 

[Dan]

Put them all in one container and give me the [where of the container so I can check them out.

 

[BBB]

Shelves

 

[Dan]

I have removed that scroll binder deed and placed the 5.0 Alchemy in its place.

TrueUO/Scripts/Items/Consumables/ScrollBinderDeed.cs at master · TrueUO/TrueUO

https://trueuo.com. Contribute to TrueUO/TrueUO development by creating an account on GitHub.

github.com

I can't seem to find the error in the code though but there is obviously something out of place here. Does anyone else see anything that sticks out to them? It is the SOT method inside the ScrollBinder.cs

 

[Bocephus]

Same issue

It will be in the center of the last chest on the right

at

Thank you

 

[Dan]

The issue is related to the comparison of double and int types in C#. When newValue (a double) and Needed (an int) are compared, there can be precision discrepancies, especially when dealing with floating-point numbers. This is why even when newValue is 5.0 and Needed is 5, they might not be considered equal due to the way floating-point numbers are represented in memory.

TrueUO/Scripts/Items/Consumables/ScrollBinderDeed.cs at master · TrueUO/TrueUO

https://trueuo.com. Contribute to TrueUO/TrueUO development by creating an account on GitHub.

github.com

I have a way to fix it but I will have to force-fix any bugged in-game.

 

[Dan]

ScrollBinderDeedBugFix by TrueUO · Pull Request #1357 · TrueUO/TrueUO

https://trueuo.com/threads/scrolls-of-transcendence-binding.3569/

github.com

Will be resolved in the next patch.

@Bocephus I went ahead and replaced the bugged binder deed with the completed 5.0 Snooping SOT.

 

[Dan]

This issue has been fixed.

@BBB has been awarded 10 Sovereigns.