FIXED potential bug with player to player trading

[supraboosta]

with a trade window open between two players, if any item is picked up from your backpack, and moved in your backpack, you get the message "you can not do that while a trade is pending". The item is then dropped to your feet.

When recalling, sometimes items move layers in your backpack. So if you have a item to sell, your runebook (or something) may appear ontop of said item, and if you move the runebook to get to the item during a trade, it will drop to you feet.

Not sure if this is intended, but it is a great way for someone to snatch an item off the ground if you are not paying attention.

 

[Dan]

This is being worked on now and has taken priority.

 

[Dan]

GitHub tracker - Issue with player to player trading and items dropping to the ground · Issue #570 · TrueUO/TrueUO (github.com)

 

[Dan]

@supraboosta a potential patch fix has been pushed to the TC. Mind testing it out a little when you get a moment, just to make sure your issue was also addressed?

 

[supraboosta]

I will test it when I get home from work in the morning

 

[Dan]

Thanks friend

 

[supraboosta]

Seems to be working correctly. Tried some different item combos, gold, messing with both players involved in the trade, and was unable to replicate any items dropping to the ground.

 

[Dan]

This issue has been fixed.

@supraboosta has been awarded 250 Sovereigns for bringing this to our attention.

 

[The Silvertiger]

I'm not sure if this is related to this fix or the container limits, but to continue our testing with the fix: