FIXED Focused Spell Damage has wrong SDI cap in PvP

[StigiBengBeng]

In Publish-96 it is said:

Focus spec spell damage increase cap reduced from 30% to 25%.

but I found in the code that its still set to 30, here is Github link (line 109):

ServUO/Scripts/Spells/Base/SpellHelper.cs at master · ServUO/ServUO

An Ultima Online server emulator written in C# .NET - ServUO/ServUO

github.com

Additionally I think that method HasSpellFocus(m, castskill) might not be working 100% correct.

Here in this wiki post:

An Introduction to Spellcasting – Ultima Online

uo.com

It is said:

In addition to the skills mentioned above: Magery & Evaluate Intelligence, Necromancy & Spiritspeak, Mysticism & Focus or Imbuing, Ninjitsu, Bushido, Chivary and Spellweaving; Animal Taming, Parry and Musicianship also count when determining whether a template is focused or not.

Example:

• A template of Magery/Evaluate Intelligence/Meditation/Inscription/Wrestling/Anatomy would be a ‘pure’ template and benefit from the cap of 25% sdi.
• A template of Magery/Evaluate Intelligence/Focus/Inscription/Wrestling/Anatomy would not – Focus belongs in the ‘mysticism’ skill set.
• A template of Magery/Evaluate Intelligence/Meditation/Animal Taming/Animal Lore/Veterinary would not – Animal Taming is on the list of skills that count.

As you can see in second example Magery/Eval template with Focus skill would not be a "Focused template", so it shouldn't have increased SDI cap, but current implementation of HasSpellFocus is not checking for supporting skills of magic schools.

 

[Dan]

Thanks for this detailed report @StigiBengBeng

Reports like this make me happy.

We will take a look.

 

[Dan]

This has been fixed.

@StigiBengBeng has been awarded 25 Sovereigns.