Not A Bug deathstrike delay is too short (not the part where you run)

[Wrenn]

when you stand still while deathstruck the damage tick is way faster than it should be

 

[Dan]

BUG REPORTING RULES

You must provide as much detail as possible when posting a bug. You must provide source information. Source information can be links to specific information on UOGuide, Stratics, UO Wiki, etc, that pertain or could pertain to your specific issue. Or they can be a very detailed report on what is...

trueuo.com

 

[Magus Zeal]

lol - but it isn't working Dan! Go research, test, hope you know what he means and fix it for him

 

[Vander Nars]

Pretty sure what he is saying is when deathstrike hits a target and they dont move it waits 3 seconds and does a lesser tick of damage. This lesser tick is happening before the 3 second window based on his comment.

However its possible that he has the window time wrong as well, deathstrike window use to be 5 seconds long. So i dont know if he is posting the bug thinking its suppose to be 5 or 3 seconds long.

 

[Magus Zeal]

Some background research from newest to oldest (patch note wise)

Ninjitsu – Ultima Online

uo.com

After receiving a Death Strike, if the opponent moves more than five steps, or three seconds elapses, they will suffer direct damage determined by the attacker’s Ninjitsu, the average of the target’s Hiding/Stealth and the number of tiles the target was tracked for. Damage in pvp capped at 50%

Publish 90 – Ultima Online

uo.com

Mastery Balance: All special abilities (Death Strike, Counter Attack …) now cancel Injected Strike.

Publish 69 16th December – Ultima Online

uo.com

Ninjitsu – Death Strike

• Reduced Death Strike damage delay to 3 seconds from 5 seconds and increased damage scale based on Ninjitsu skill. Death strike damage capped at 50 verses players.

Publish 46 9th August – Ultima Online

uo.com

• Death Strike will now cause 50% less damage when using a ranged weapon.
• Death Strike damage cap lowered from 70 to 60.
• Death Strike damage now scales based on the average of Hiding/Stealth from 30% to 100% of normal damage.

Publish 40 5th May – Ultima Online

uo.com

Death Strike now clears its stalking bonus correctly. This fix also effects Backstab and Surprise Attack

Publish 32 14th April – Ultima Online

uo.com

Death Strike is now capped at 60 damage if the target moves and 20 damage if the target doesn’t move, with 66% of the damage determined by the ninjitsu skill of the attacker and 33% of the damage determined by the number of tiles the target was tracked for.

Post automatically merged: Jul 14, 2020

Publish 28 12th January – Ultima Online

uo.com

Death Strike will now inflict Direct damage instead of Physical damage.

Post automatically merged: Jul 14, 2020

Summary:
I'm reading its 3 seconds or 5 steps and true damage is distributed 2/3 skill, 1/3 stalking capped at 50 in pvp. 50% penalty for ranged

Post automatically merged: Jul 14, 2020

The code seems to check out:

ServUO/Scripts/Spells/Ninjitsu/DeathStrike.cs at 470f62cdba63a5752c20cf5e020e72a5dcc26a71 · ServUO/ServUO

An Ultima Online server emulator written in C# .NET - ServUO/ServUO

github.com

3 second delay

 public static readonly TimeSpan DamageDelay = TimeSpan.FromSeconds(3.0);

damage reduction if steps < 5 or if ranged - not sure the stalking bonus makes sense though...seems to divide damage by 3 if you dont get 5 steps? Probably should be tested.

private static void ProcessDeathStrike(DeathStrikeInfo info)
        {
            var damage = info._Damage;

            if (info._isRanged)
                damage /= 2;

            if (info._Steps < 5)
                damage /= 3;

Direct Damage is there

AOS.Damage(info._Target, info._Attacker, damage, 0, 0, 0, 0, 0, 0, 100); // Damage is direct.

Damage cap for pvp is there

if (_totaldamage > 50 && attacker is PlayerMobile && defender is PlayerMobile)
                _totaldamage = 50;

Post automatically merged: Jul 14, 2020

Distribution 1/3 stalking, 2/3 skill (not sure if this is what its doing but SOMETHING is going on! This doesn't seem to factor in the stalking bonus....so probably needs to be looked at here. I don't think this part agrees with Publish 32

var avarage = (hiding + stealth) / 100;

            var scalar = ninjitsu / 9;

            var basedamage = ninjitsu / 5.7;

            var _totaldamage = (int)(basedamage + (avarage * scalar));

 

[Magus Zeal]

Anyways, the 3 second thing is a thing (@Mrriots wife says so at least), so not a bug? The stalking bonus and damage spread between stalking and skill - may be up for some testing should someone wanna make an EJ account and burn 30min

 

[Dan]

Yeah looks good to me. Thanks, @DaBeanCounter for grabbing those patch notes.