FIXED Crashes 8/27/2018 around 9-10pm PST

[Jester]

I believe i found a bug that is causing the server to crash, I made it happen the first time as curiosity got me as to what it does, but the second time was to test if it crashed the server..

On the Enhanced client, if you click this button when it lights up (get close enough to the target) it seems to crash the server (I assume it is a quick tame button?)



I happened to be messing with the Cu Sidhe's but i imagine that anytime this button is clicked it would crash the server.

Now i cannot figure out what exact conditions have to be met for this icon to show, as i was able to get it to show for this screen shot and one more time by tabbing randomly but not since then.

I would have tried it a 3rd time to test it, but did not want the server to revert annoying everyone, not to mention having to kill Meph a 4th time.

***Edit***

I believe it is a quick tame option as i stabled my Cu and went to check tameables and it shows up (did not want to click on it in case it is the button itself), which is where i believe the bug lies. My Cu is 5/5, so if that shows up and i attempt to tame it crashes

 

[Dan]

@Dexter

ServUO Version 0.5, Build 6813.27041
Operating System: Microsoft Windows NT 6.2.9200.0
.NET Framework: 4.0.30319.42000
Time: 8/28/2018 4:04:18 AM
Mobiles: 48281
Items: 407928
Exception:
System.NullReferenceException: Object reference not set to an instance of an object.
   at Server.Mobiles.BaseCreature.TameEntry.OnClick()
   at Server.Network.PacketHandlers.ContextMenuResponse(NetState state, PacketReader pvSrc)
   at Server.Network.MessagePump.HandleReceive(NetState ns)
   at Server.Network.MessagePump.Slice()
   at Server.Core.Main(String[] args)

 

[Dan]

Debug crash log

Exception:
System.NullReferenceException: Object reference not set to an instance of an object.
   at Server.Mobiles.BaseCreature.TameEntry.OnClick() in c:\Users\Administrator\Desktop\Heritage\trunk\Scripts\Mobiles\Normal\BaseCreature.cs:line 4489
   at Server.Network.PacketHandlers.ContextMenuResponse(NetState state, PacketReader pvSrc)
   at Server.Network.MessagePump.HandleReceive(NetState ns)
   at Server.Network.MessagePump.Slice()
   at Server.Core.Main(String[] args)

 

[Dan]

public override void OnClick()
            {
                if (!Owner.From.CheckAlive())
                {
                    return;
                }

                Owner.From.TargetLocked = true;
                AnimalTaming.DisableMessage = true;

                if (Owner.From.UseSkill(SkillName.AnimalTaming))
                {
                    Owner.From.Target.Invoke(Owner.From, m_Mobile);
                }

                AnimalTaming.DisableMessage = false;
                Owner.From.TargetLocked = false;
            }

 

[Dan]

Owner.From.Target.Invoke(Owner.From, m_Mobile); = line 4489

 

[Dexter]

This is new, yes? Looks like it’s due to the delay vorspire put in. I’ll take a close look when I get home.

 

[Dan]

Yeah brand new. Running newest code as of yesterday.

 

[Dexter]

Yep. This’ll have to be reworked.

 

[Dan]

This issue has been fixed.

@Jester has been awarded 20 Sovereigns on UOH.