FIXED -5 Mage crafted mage weapon property

[Xan Swiftwind]

I recently made a warhammer that was crafted with -5 mage weapon property on it and I may be wrong but unless you changed things here, that's below the limit. Here's the pic of it:

 

[Dan]

I'm going to move this to general discussion since no source post or supporting information on caps or reforging.

BUG REPORTING RULES

You must provide as much detail as possible when posting a bug. You must provide source information. Source information can be links to specific information on UOGuide, Stratics, UO Wiki, etc, that pertain or could pertain to your specific issue. Or they can be a very detailed report on what is...

trueuo.com

If anyone has links to why this might be wrong please post below.

 

[FireFly]

There you go

Magic Item Properties – Ultima Online

uo.com

According to (R) stand for reforged
-15 should be max possible intensity

 

[Dan]

Okay and reforging dosent have an effect on that?

What runic? What reforging option? Steps to replicate?

 

[Dan]

TrueUO/Scripts/Services/LootGeneration/RunicReforging/RunicReforging.cs at master · TrueUO/TrueUO

https://trueuo.com. Contribute to TrueUO/TrueUO development by creating an account on GitHub.

github.com

        public static readonly int[][] MageWeaponTable =
        {
            new[] { 25, 20, 20, 20, 20, 15, 15 },
            new[] { 20, 20, 20, 15, 15, 15, 15 },
            new[] { 20, 15, 15, 15, 15, 15, 15 },
            new int[] { },
            new[] { 20, 20, 20, 15, 15, 15, 15 },
            new[] { 15, 15, 15, 15, 15, 15, 15 }
        };

Because, code wise, I can't see it yet.

 

[Xan Swiftwind]

Thanks FireFly, and next time I will try to provide more info Dan.

 

[Dan]

How can I replicate what you did to get the -5?

What runic and reforging option were you using?

 

[Xan Swiftwind]

I was using a Dull Copper Runic to reforge it with Grand Artifice and Inspired Artifice: Exquisite/of Quality. Sorry I didn't say that sooner.

 

[Dan]

I was using a Dull Copper Runic to reforge it with Grand Artifice and Inspired Artifice: Exquisite/of Quality. Sorry I didn't say that sooner.

Thanks, code wise I don't see it. However if it spit that out, and reforging dosent change caps in anyway. I'll next have to try to replicate it myself while adding in break points code side to detect the location where the math diverts from what it should be doing.

 

[RedBeard]

Had this happen with oak or ash saws on Bokutos. Mage weapon below -15

 

[Dan]

I think I got the math right but would appreciate another set of eyes.

Mage Weapon Table by TrueUO · Pull Request #1039 · TrueUO/TrueUO

Appears to have been always been way off. Would appreciate another set of eyes. https://uo.com/wiki/ultima-online-wiki/items/magic-item-properties/ cap info taken from here.

github.com

Old

public static readonly int[][] MageWeaponTable =
        {
            new[] { 25, 20, 20, 20, 20, 15, 15 },
            new[] { 20, 20, 20, 15, 15, 15, 15 },
            new[] { 20, 15, 15, 15, 15, 15, 15 },
            new int[] { },
            new[] { 20, 20, 20, 15, 15, 15, 15 },
            new[] { 15, 15, 15, 15, 15, 15, 15 }
        };

-5, -10, -15

New

public static readonly int[][] MageWeaponTable =
        {
            new[] { 15, 10, 10, 10, 10, 5, 5 },
            new[] { 10, 10, 10, 5, 5, 5, 5 },
            new[] { 10, 5, 5, 5, 5, 5, 5 },
            new int[] { },
            new[] { 10, 10, 10, 5, 5, 5, 5 },
            new[] { 5, 5, 5, 5, 5, 5, 5 }
        };

-15, -20, -25.

 

[Dan]

This issue has been fixed.

@Xan Swiftwind has been awarded 50 Sovereigns for bringing this to our attention.