FIXED Yet ANOTHER imbuing bug.

[DewCono]

I'm trying to imbue a 5th mod onto the following 4 items. All 4 items in the imbuing menu, and in the loot inspector show 4/5 mods, and open imbuing weight. NONE of these 4 can fit another mod at all.



So I went on OSI to test if Mage armor or MR4 took extra mod slots, or something.




So there's no conflict there. Something is causing these item to not be imbuable on Heritage. Whether it's Mage armor, or MR4 thats the only common trend between all 4 of those items.

 

[DewCono]

Based on the error message I receive when attempting to do the imbue: "You cannot imbue this item with any more item properties." it must be one of these two sections that are behaving improperly.

ServUO/Scripts/Services/LootGeneration/Imbuing/Core/Imbuing.cs at 072b4548a561a34fb9c36c4d0450962945abb387 · ServUO/ServUO

An Ultima Online server emulator written in C# .NET - ServUO/ServUO

github.com

Lines 348-365

           {
                var maxWeight = GetMaxWeight(i);
                context.Imbue_IWmax = maxWeight;

                var trueWeight = GetTotalWeight(i, id, false, true);
                var imbuingWeight = GetTotalWeight(i, id, true, true);
                var totalItemMods = GetTotalMods(i, id);
                var maxint = ItemPropertyInfo.GetMaxIntensity(i, id, true);

                var propImbuingweight = (int)(((double)def.Weight / (double)maxint) * value);
                var propTrueWeight = (int)(((double)propImbuingweight / (double)def.Weight) * 100);

                if ((imbuingWeight + propImbuingweight) > maxWeight)
                {
                    from.SendLocalizedMessage(1079772); // You cannot imbue this item with any more item properties.
                    from.CloseGump(typeof(ImbueGump));
                    return;
                }

Lines 114-129

       public static bool OnBeforeImbue(Mobile from, Item item, int id, int value, int totalprops, int maxprops, int totalitemweight, int maxweight)
        {
            if (totalprops >= maxprops || totalitemweight > maxweight)
            {
                from.SendLocalizedMessage(1079772); // You cannot imbue this item with any more item properties.
                from.CloseGump(typeof(ImbueGump));
                from.EndAction(typeof(Imbuing));
                return false;
            }

            return true;
        }

I feel like it's the first snippet of code that is more at play since the items are under max props, and are under max weight as well.

 

[Dexter]

What are you trying to imbue? And what value?

 

[DewCono]

I literally cannot imbue LRC 1% to any of those 4 items.
It may seem odd, but I feel like for some reason it's behaving as if there are multiple instances of mana regen on it making it think there are 5 mods. If you can log into Discord for a moment I will elaborate.

 

[Dan]

This issue has been fixed.

@DewCono has been awarded 20 Sovereigns.